replace to v0.9.40 for the farming feature ONLY #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bifrost-farming-rpc-api and bifrost-farming-rpc-runtime-api works.
ebma
reviewed
May 22, 2023
There was a problem hiding this comment.
I assume the compilation of the other pallets would not work anymore since you only added code changes to the farming pallet while updating the dependencies everywhere. Which is not problematic since we are only interested in the farming pallet anyways.
Did you test that the compilation of that pallet still works though? I can see that it relies on the local code in node/primitives. Just want to make sure that this does not require changes too.
It's a great idea to only add changes for the farming pallet and ignore the rest if possible IMO 👍
|
@ebma i ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially closes pendulum issue 219
update 3 packages:
bifrost-farming-rpc-runtime-apibifrost-farming-rpc-apibifrost-farming