New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to version `polkadot-v0.9.40` #242

Merged

ebma merged 24 commits into main from 219-update-runtimes-to-polkadot-v0940

Jul 6, 2023

Contributor

b-yap commented May 30, 2023 •

edited

Loading

closes #219

not yet ready! Just visibility on the changes I've done so far. Added comments on where I got the changes too.

Update: development-runtime should compile fine.

b-yap commented

View reviewed changes

runtime/foucoco/src/lib.rs Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/foucoco/src/lib.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/foucoco/src/lib.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/foucoco/src/lib.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/foucoco/src/xcm_config.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/foucoco/src/xcm_config.rs Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/foucoco/src/xcm_config.rs Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/foucoco/src/xcm_config.rs Outdated Show resolved Hide resolved

b-yap requested review from ebma and TorstenStueber

June 1, 2023 12:18

b-yap commented

View reviewed changes

runtime/foucoco/src/xcm_config.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/foucoco/src/xcm_config.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

node/src/service.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

node/src/service.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

node/src/service.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

node/src/service.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/integration-tests/pendulum/src/tests.rs Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/integration-tests/pendulum/Cargo.toml Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/pendulum/src/lib.rs Show resolved Hide resolved

b-yap force-pushed the 219-update-runtimes-to-polkadot-v0940 branch from 2a0227b to 19dceb0 Compare

June 12, 2023 08:29

b-yap marked this pull request as ready for review

June 12, 2023 08:30

ebma reviewed

View reviewed changes

Member

ebma left a comment

It looks good overall. Hard to say if everything is correct since it's just so much that changed. Thanks, @b-yap for commenting with code links on the more critical/confusing parts 👍 I marked most of them as resolved to indicate acknowledgment. Although maybe I should have waited for fellow reviewers to also read them before doing that.

node/src/service.rs Show resolved Hide resolved

pallets/parachain-staking/src/benchmarking.rs Outdated Show resolved Hide resolved

runtime/amplitude/src/xcm_config.rs Show resolved Hide resolved

runtime/amplitude/src/xcm_config.rs Show resolved Hide resolved

runtime/development/src/xcm_config.rs Outdated Show resolved Hide resolved

runtime/development/src/xcm_config.rs Outdated Show resolved Hide resolved

runtime/development/src/xcm_config.rs Show resolved Hide resolved

runtime/integration-tests/pendulum/Cargo.toml Outdated Show resolved Hide resolved

runtime/pendulum/src/xcm_config.rs Outdated Show resolved Hide resolved

b-yap added a commit that referenced this pull request


          https://github.com/pendulum-chain/pendulum/pull/242#discussion_r12263…

0e20e72

…30963,

#242 (comment),
#242 (comment),
#242 (comment)

b-yap commented

View reviewed changes

runtime/integration-tests/pendulum/src/tests.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/pendulum/src/weights/pallet_xcm.rs Outdated Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/pendulum/src/xcm_config.rs Show resolved Hide resolved

b-yap commented

View reviewed changes

runtime/pendulum/src/xcm_config.rs Show resolved Hide resolved

b-yap requested a review from ebma

June 20, 2023 10:09

adelarja mentioned this pull request

241 update spacewalk dependencies and configure the lp token for use with the zenlink pallet #246

Merged

ebma approved these changes

View reviewed changes

Member

ebma left a comment

Thanks for all your work @b-yap. I re-reviewed and it looks good to me. Although it's quite a lot of changes and hard to grasp all of it.

Just a question regarding the benchmarks. It's great that we have them, and also for the other pallets. Was this a requirement by the new Polkadot version that the WeightInfo field cannot be empty?

runtime/amplitude/src/lib.rs Show resolved Hide resolved

runtime/amplitude/Cargo.toml Show resolved Hide resolved

runtime/development/Cargo.toml Outdated Show resolved Hide resolved

runtime/integration-tests/pendulum/src/lib.rs Outdated Show resolved Hide resolved

Cargo.toml Show resolved Hide resolved

b-yap force-pushed the 219-update-runtimes-to-polkadot-v0940 branch from 742f7a7 to 4dca813 Compare

July 6, 2023 05:09

b-yap added 23 commits

July 6, 2023 15:13


          first iteration: fixes the development-runtime package.


          fixed some errors in foucoco runtime. Not yet finished.

38476cd


          new iteration, fixing foucoco-runtime

0e8ab2d


          set network to None

64dd6e9


          fix foucoco runtime and update spacewalk tag

1d158bc


          bring back FungiblesAdapter

62ff16e


          fix amplitude-runtime

ad74ead


          fix pendulum-runtime

09c1535


          fix node

8dabdc0


          cleanup some test build errors

3b5c451


          add .lock

b43fe2d


          fix test build issues

ffe9f8b


          fix test build issues of parachain-staking.

39761da

The order of the pallets during runtime construction has changed.
see KILTprotocol/kilt-node#416


          https://github.com/pendulum-chain/pendulum/pull/242#discussion_r12263…

c048b01

…30963,

#242 (comment),
#242 (comment),
#242 (comment)


          partially fixed test integration test cases

a5a2b47


          fixed test integration test cases

dbe1ae4


          remove extern crate core

ac0adce


          revert comment println

f95f573


          tried to fix the benchmark, but to no avail.

db612d4


          fix benchmark and added weights

229825d


          add cargo lock

c44d446


          https://github.com/pendulum-chain/pendulum/pull/242#discussion_r12387…

229af34

…57832,

#242 (comment),


          change spec versions

09176d4

b-yap force-pushed the 219-update-runtimes-to-polkadot-v0940 branch from 4dca813 to 09176d4 Compare

July 6, 2023 07:13


          revert version

ebma self-requested a review

July 6, 2023 10:11

ebma approved these changes

View reviewed changes

Member

ebma left a comment

I closed the unresolved conversations now and will approve and merge.

ebma merged commit 72ac423 into main

ebma deleted the 219-update-runtimes-to-polkadot-v0940 branch

July 6, 2023 10:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet