Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

460 take token decimals into account for price conversions in treasury buyout #461

Merged
merged 7 commits into from
May 13, 2024
Merged

460 take token decimals into account for price conversions in treasury buyout #461

merged 7 commits into from
May 13, 2024

Conversation

bogdanS98
Copy link
Contributor

@bogdanS98 bogdanS98 commented May 8, 2024 •
edited
Loading

Closes #460.

Spacewalk dependencies were updated because these changes were needed.

@bogdanS98 bogdanS98 linked an issue May 8, 2024 that may be closed by this pull request
Take token decimals into account for price conversions in treasury buyout #460
Closed
@bogdanS98 bogdanS98 marked this pull request as ready for review May 9, 2024 12:29
@bogdanS98 bogdanS98 requested a review from a team May 9, 2024 12:31
@bogdanS98
Copy link
Contributor Author

Tested buyouts with chopsticks (Pendulum) by exchanging DOT (10 decimals) for PEN (12 decimals):

Using buyout amount of 0.1 PEN as input:
image
Using exchange amount of 0.001 DOT as input:
image

ebma
ebma reviewed May 13, 2024
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also replace the DecimalsLookup that we define for the oracle to point to the new custom implementation, e.g. here.

node/Cargo.toml Outdated Show resolved Hide resolved
pallets/treasury-buyout-extension/src/mock.rs Outdated Show resolved Hide resolved
pallets/treasury-buyout-extension/src/tests.rs Outdated Show resolved Hide resolved
pallets/treasury-buyout-extension/src/tests.rs Outdated Show resolved Hide resolved
pallets/treasury-buyout-extension/src/tests.rs Outdated Show resolved Hide resolved
runtime/amplitude/src/lib.rs Outdated Show resolved Hide resolved
ebma
ebma approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me 👍

@bogdanS98 bogdanS98 merged commit 0ac14ea into main May 13, 2024
2 checks passed
@bogdanS98 bogdanS98 deleted the 460-take-token-decimals-into-account-for-price-conversions-in-treasury-buyout branch May 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take token decimals into account for price conversions in treasury buyout
2 participants
@bogdanS98 @ebma