Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

445 replace oraclekey enums used in treasury buyout extension #471

Merged

Conversation

bogdanS98
Copy link
Contributor

This PR modifies PriceGetter trait implementation by replacing usage of oracle pallet with dia-oracle.
PriceGetter is a trait that is used to fetch prices of assets when doing buyouts.

Closes #445.

@bogdanS98 bogdanS98 requested a review from a team May 16, 2024 16:03
@bogdanS98 bogdanS98 linked an issue May 16, 2024 that may be closed by this pull request
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's generify and deduplicate the OraclePriceGetter and put it into the common directory, similar to what I did with the struct here.

runtime/common/src/lib.rs Outdated Show resolved Hide resolved
runtime/common/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…o 445-replace-oraclekey-enums-used-in-treasury-buyout-extension
@ebma ebma self-requested a review May 17, 2024 11:07
@bogdanS98 bogdanS98 merged commit 5e97706 into main May 17, 2024
3 checks passed
@bogdanS98 bogdanS98 deleted the 445-replace-oraclekey-enums-used-in-treasury-buyout-extension branch May 17, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace OracleKey enums used in treasury-buyout-extension
2 participants