Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Whats wrong with this theme file? #4

Open
millisami opened this issue Dec 14, 2011 · 4 comments
Open

Whats wrong with this theme file? #4

millisami opened this issue Dec 14, 2011 · 4 comments

Comments

@millisami
Copy link

The theme I want to customize is the Effector theme.

This is the html theme file: https://gist.github.com/1475351#file_theme.html

And this is the compiled one: https://gist.github.com/1475351#file_compiled_theme.html

Do look at the compiled file, its not being parsed properly.

Other theme files such as demo, 101, ... gets parsed correctly.

Whats wrong with this theme file that Thimblr cannot parse it correctly?

@millisami
Copy link
Author

While digging into it, I figured out that if the meta has spaces in between, it doesn't get parsed by the thimblr.

e.g.

<meta name="font:Outside Text" content="Helvetica Neue, Arial, sans-serif"/>
<meta name="color:Outside Text" content="#616566"/>
body { font-family:{font:Outside Text}; color:{color:Outside Text};

The rendered html is:

body { font-family:{font:Outside Text}; color:{color:Outside Text};

But when the spaces in between are removed, .e.g <meta name="font:OutsideText" .., it parses for this attribute only.

If this is the case, then I've to remove the spaces from every meta tags.

So I think its a bug inside the Thimblr or am I doing it wrong?

@millisami
Copy link
Author

Though I've removed every spaces for those meta tags, not all are parsed correctly.

Is the themefile or source of thechangelog.com is released publicly? So that I can look into it.

@pengwynn
Copy link
Owner

I'm not currently using fumblr for The Changelog, since we're migrating off Tumblr for that site. The parser is simply thimblr under the hood. You might post your question there.

@millisami
Copy link
Author

Alright!!

Actually I'd posted at thimblr jphastings/thimblr#7

Didn't hear anything back, so that I posted here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants