WIP: sublet #274
WIP: sublet #274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 91.50% 91.46% -0.04%
==========================================
Files 60 60
Lines 2542 2542
==========================================
- Hits 2326 2325 -1
- Misses 216 217 +1 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,7 @@ | |||
| "use client" | |||
There was a problem hiding this comment.
is this ui folder completely custom or from somewhere? if its from somewhere else is there anyway we can just yarn install and then import it?
There was a problem hiding this comment.
is there any reason we manually put in the font files? (similar to the ui folder, can we just import the font?)
sublet/public/hamco.jpeg
Outdated
There was a problem hiding this comment.
assuming this is just for testing?
sublet/public/icons/analytics.svg
Outdated
There was a problem hiding this comment.
should we consider using a icon library? (for sake of ease + easier to use in future)
sublet/public/landing-page.jpg
Outdated
There was a problem hiding this comment.
if these landing page images and icons are going to be shared by both sublet and portal we should probably eventually just put them in a shared place so we only have 1 copy
sublet/services/propertyService.ts
Outdated
|
|
||
| // Throw a new error with the error message | ||
| throw new Error(errorMsg); | ||
| } |
There was a problem hiding this comment.
also if you are doing the same error checking each time also best to extract to a function
sublet/utils/csrf.ts
Outdated
There was a problem hiding this comment.
I assume these files are remnants from portal that you copied over?
| fetchProperties() | ||
| .then((data) => { | ||
| setProperties(data); | ||
| }) |
There was a problem hiding this comment.
nit: fetchProperties().then(setProperties); should also work
| }); | ||
|
|
||
| return formattedDate; | ||
| } |
There was a problem hiding this comment.
probably best to have this in a util folder (perhaps globally shared)
sublet/Pipfile
Outdated
There was a problem hiding this comment.
i don't think we need a pipfile here?
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9451515 | Triggered | Generic Password | a8161b4 | .github/workflows/cdkactions_build-and-deploy.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
for vincent