Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Buf Lint workflow to PRs against main #3292

Closed
hdevalence opened this issue Nov 8, 2023 · 0 comments · Fixed by #3297
Closed

Restrict Buf Lint workflow to PRs against main #3292

hdevalence opened this issue Nov 8, 2023 · 0 comments · Fixed by #3297

Comments

@hdevalence
Copy link
Member

hdevalence commented Nov 8, 2023 •
edited
Loading

I think it's comparing the state of this branch against main, even though the PR is being made against a different branch. Probably the solution is to change the CI workflow to filter to only apply to PRs against main.

Originally posted by @hdevalence in #3291 (comment)
@conorsch conorsch mentioned this issue Nov 8, 2023
Merged
conorsch added a commit that referenced this issue Nov 8, 2023
@conorsch
ci: only run buf lint on PRs against main
064ddb6 
Also ensures we're using the most recent stable version of buf
across all workflows, via the `v1` version specifier.

Closes #3292.
@conorsch conorsch mentioned this issue Nov 8, 2023
Merged
conorsch added a commit that referenced this issue Nov 9, 2023
@conorsch
ci: only run buf lint on PRs against main
78a85fd 
Also ensures we're using the most recent stable version of buf
across all workflows, via the `v1` version specifier.

Closes #3292.
conorsch added a commit that referenced this issue Nov 16, 2023
@conorsch
ci: only run buf lint on PRs against main
babdbf0 
Also ensures we're using the most recent stable version of buf
across all workflows, via the `v1` version specifier.

Closes #3292.

(cherry picked from commit 78a85fd)
conorsch added a commit that referenced this issue Nov 16, 2023
@conorsch
ci: only run buf lint on PRs against main
7f89bf4 
Also ensures we're using the most recent stable version of buf
across all workflows, via the `v1` version specifier.

Closes #3292.

(cherry picked from commit 78a85fd)
conorsch added a commit that referenced this issue Jan 4, 2024
@conorsch
ci: fix buf workflow on PRs
b2dc047 
Follow up to #3292, which incorrectly used `pull_request_target` rather
than `pull_request` to restrict workflow runs to PRs targeting main. We
still want to skip the buf workflows if the PR is targeting a feature
branch.

Closes #3570.
@conorsch conorsch mentioned this issue Jan 4, 2024
Merged
conorsch added a commit that referenced this issue Jan 4, 2024
@conorsch
ci: fix buf workflow on PRs
d3471c3 
Follow up to #3292, which incorrectly used `pull_request_target` rather
than `pull_request` to restrict workflow runs to PRs targeting main. We
still want to skip the buf workflows if the PR is targeting a feature
branch.

Closes #3570.
hdevalence pushed a commit that referenced this issue Jan 4, 2024
@conorsch @hdevalence
ci: fix buf workflow on PRs
b3204b1 
Follow up to #3292, which incorrectly used `pull_request_target` rather
than `pull_request` to restrict workflow runs to PRs targeting main. We
still want to skip the buf workflows if the PR is targeting a feature
branch.

Closes #3570.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Testnets
Status: Testnet 63: Rhea (Web Wallet)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: only run buf lint on PRs against main penumbra-zone/penumbra
1 participant
@hdevalence