-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase/Rebuild Penumbra Hermes support on top of backend-specific configs #3477
Comments
Haven't been able to get Hermes building against 64 yet. Here's what I tried:
Even after all that, I'm stuck on trait problems. @avahowell can you give it a go? I recommend starting from step 1 above, on a clean branch of the hermes fork. Once we have a clean build against |
@conorsch if i want to take a look, i should checkout that d8c0245 commit and run |
@erwanor That's right! Don't forget to manually increment the |
This issue is for rebuilding Hermes support on top of backend-specific configs. We shouldn't be checking out random git commits and attempting to patch them up. We should be using the rewritten code. What branch does that live in? |
The git commit referenced above is the current |
Yes, that code is not to be maintained or developed going forward. This issue is tracking rebuilding Hermes support on top of the changes we merged upstream two months ago. What happened to that effort? |
I've set the
Those changes are necessary but not sufficient for restoring Penumbra compatibility in Hermes, but our goal is to leave that codebase behind, and use it only as a reference. Next steps should be:
|
No, we need to be using that repo to develop our Hermes integration. I unarchived it. The point of this issue is that we need to rebuild Penumbra support, in that repo, on top of the changes we were able to merge upstream in the issue linked above, so that the code is maintainable going forward. |
Not sure if it is worth aiming at but since #3531 landed it may be possible to have Penumbra Hermes support not use ABCI Query interface at all. we could perhaps at the astria relayer code for an example. |
We discussed this at sync today. Right now, Hermes is working against Testnet 64, although it's still built against Testnet 63 dependencies. That's "good enough" for now, so we plan to hold steady with the same setup on Testnet 65. If things break, we'll prioritize rebasing at that point. For now, it's higher priority to work with Astria on their IBC needs. Separately, it would be nice to have a Hermes instance running against preview, so we could monitor compatibility more closely. |
Work is active on this front, see penumbra-zone/hermes#12. However, we don't intend to block release of 65 (#3554) in order to land these changes. |
Update from IBC sync today: @avahowell is optimistic about having PR against upstream by Friday, 2024-02-09. We'd love to see it land upstream, but either way, once it's working, we can start using it again on Testnet 65. We'll miss go-live of 65, so let's aim to follow up with a Hermes deploy on or around Monday 2024-02-12. |
Overview on the progress and remaining items here (pr: penumbra-zone/hermes#12):
|
Yet another update: @avahowell now expects a PR to be ready for review by this Friday, 2024-02-23. New commits landing the boxed gRPC services (#3711) in the Hermes code have been pushed to the WIP PR branch. The checklist above is still accurate: config changes are in, and the code compiles, but there's still active debugging towards getting relaying working between Penumbra devnet chains. |
I was able to successfully test:
We should do a review pass on the code in penumbra-zone/hermes#12 in order to ensure that the approach taken will be maintainable going forward, both from a penumbra perspective (we're using the penumbra crates to build txs now) and a hermes perspective. |
Is your feature request related to a problem? Please describe.
Our initial attempt at Hermes support for Penumbra was done as a one-off, since Hermes didn't have support for non-Cosmos chains. Since then we landed informalsystems/hermes#3636 and can rebuild a Penumbra backend on top of new Hermes.
The text was updated successfully, but these errors were encountered: