tests: 🧩 provide a block builder api in the mock consensus engine #3792
Assignees
Labels
A-mock-consensus
Area: Relates to the mock consensus engine
C-enhancement
Category: an enhancement to the codebase
_P-high
High priority
Milestone
Comments
cratelyn
added
C-enhancement
|
xref #3816 (comment) I think this might make sense to prioritize over the genesis data adjustment. |
|
sounds good to me, i will work on this first. thank you for the heads up! |
|
work-in-progress pr is at #3822. 🔨 |
cratelyn
added a commit
that referenced
this issue
Feb 15, 2024
fixes #3792. see #3588. * `block` module defining interfaces to build a tendermint block, holding a unique reference to the `TestNode`. * `abci` module defining `TestNode` interfaces that will send consensus requests to the application. this includes: * BeginBlock * DeliverTx * EndBlock * Commit * `send_block` module defining a `TestNode` interface to send the requisite abci requests, given a `tendermint::Block`. * documentation is added for assorted public interfaces. this represents a huge, exciting step for work on the mock engine! we can now initialize and send an (empty) block to the consensus service. ✨ 🎊 ✨ 🎊 ✨ what next? this isn't a _comprehensive_ set of interfaces. `penumbra_mock_consensus::block::Builder` will certainly grow more methods as it is iterated upon. we'll use work in porting tests (see #3788) to drive which other fields are needed. forthcoming work will build upon this to: * introduce more builder methods to set other `Header` fields (e.g. timestamp, see #3759) * use the reference to the test node to set other `Header` fields (e.g. height) todo comments are left to that effect. --- * #3588 * #3792
cratelyn
added a commit
that referenced
this issue
Feb 15, 2024
fixes #3792. see #3588. * `block` module defining interfaces to build a tendermint block, holding a unique reference to the `TestNode`. * `abci` module defining `TestNode` interfaces that will send consensus requests to the application. this includes: * BeginBlock * DeliverTx * EndBlock * Commit * `send_block` module defining a `TestNode` interface to send the requisite abci requests, given a `tendermint::Block`. * documentation is added for assorted public interfaces. this represents a huge, exciting step for work on the mock engine! we can now initialize and send an (empty) block to the consensus service. ✨ 🎊 ✨ 🎊 ✨ what next? this isn't a _comprehensive_ set of interfaces. `penumbra_mock_consensus::block::Builder` will certainly grow more methods as it is iterated upon. we'll use work in porting tests (see #3788) to drive which other fields are needed. forthcoming work will build upon this to: * introduce more builder methods to set other `Header` fields (e.g. timestamp, see #3759) * use the reference to the test node to set other `Header` fields (e.g. height) todo comments are left to that effect. --- * #3588 * #3792
cratelyn
added a commit
that referenced
this issue
Feb 20, 2024
`tendermint::evidence::List` implements `std::default::Default`. so, let's use that instead of mandating that an empty evidence list be provided each time that we build a new block. #3840 (comment) Reference: #3588 Reference: #3792 Reference: #3840 Co-Authored-By: Henry de Valence <[email protected]>
cratelyn
added a commit
that referenced
this issue
Feb 20, 2024
`tendermint::evidence::List` implements `std::default::Default`. so, let's use that instead of mandating that an empty evidence list be provided each time that we build a new block. #3840 (comment) Reference: #3588 Reference: #3792 Reference: #3840 Co-Authored-By: Henry de Valence <[email protected]>
cratelyn
added a commit
that referenced
this issue
Feb 20, 2024
`tendermint::evidence::List` implements `std::default::Default`. so, let's use that instead of mandating that an empty evidence list be provided each time that we build a new block. #3840 (comment) Reference: #3588 Reference: #3792 Reference: #3840 Co-authored-by: Henry de Valence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
see #3588.
The text was updated successfully, but these errors were encountered: