Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: 🔀 expose fast forward facilities in mock consensus engine #3933

Closed
cratelyn opened this issue Mar 4, 2024 · 0 comments · Fixed by #4002
Closed

tests: 🔀 expose fast forward facilities in mock consensus engine #3933

cratelyn opened this issue Mar 4, 2024 · 0 comments · Fixed by #4002
Assignees
@cratelyn
Labels
A-mock-consensus Area: Relates to the mock consensus engine
Milestone
Sprint 2

Comments

@cratelyn
Copy link
Contributor

cratelyn commented Mar 4, 2024

see #3588.

#3759 outlines the need for facilities to allow tests to "fast forward" and otherwise manipulate the clock that is used to generate timestamps. this will be useful for testing things like IBC.

we will also need the ability to easily fast forward a certain number of blocks. other facilities in the staking component use the rate of blocks as a measure of time.
@cratelyn cratelyn added the A-mock-consensus Area: Relates to the mock consensus engine label Mar 4, 2024
@cratelyn cratelyn mentioned this issue Mar 4, 2024
Closed
cratelyn added a commit that referenced this issue Mar 12, 2024
@cratelyn
mock-consensus: 󰒭 test node can fast_forward
cd831f8 
fixes #3933.

this introduces a `fast_forward` method to a test node, allowing tests
using the mock consensus engine (#3588) to fast forward a certain number
of blocks.

the existing `mock_consensus_can_send_a_sequence_of_empty_blocks` test
is rewritten to make use of this method.

this is done in service of #3995.

---

* #3588
* #3933
* #3995
cratelyn added a commit that referenced this issue Mar 12, 2024
@cratelyn
mock-consensus: 🔀 test node can fast_forward
a2f5218 
fixes #3933.

this introduces a `fast_forward` method to a test node, allowing tests
using the mock consensus engine (#3588) to fast forward a certain number
of blocks.

the existing `mock_consensus_can_send_a_sequence_of_empty_blocks` test
is rewritten to make use of this method.

this is done in service of #3995.

---

* #3588
* #3933
* #3995
@cratelyn cratelyn mentioned this issue Mar 12, 2024
Merged
cratelyn added a commit that referenced this issue Mar 12, 2024
@cratelyn
mock-consensus: 🔀 test node can fast_forward (#4002)
0dcba24 
fixes #3933.

this introduces a `fast_forward` method to a test node, allowing tests
using the mock consensus engine (#3588) to fast forward a certain number
of blocks.

the existing `mock_consensus_can_send_a_sequence_of_empty_blocks` test
is rewritten to make use of this method.

this is done in service of #3995.

---

* #3588
* #3933
* #3995
@cratelyn cratelyn added this to the Sprint 2 milestone Mar 12, 2024
@cratelyn cratelyn self-assigned this Mar 12, 2024
cratelyn added a commit that referenced this issue Mar 13, 2024
@cratelyn
feat(mock-consensus): ➰ record height in inner span
8d55d49 
this tweaks the fast-forward facilities (#3933, #4002) so that we record
the height as a span field per-loop iteration, not as a field in the
encompassing `#[instrument]` span.

see #4005 for an example of the misleading `height: 0` logs this would
generate.
cratelyn added a commit that referenced this issue Mar 15, 2024
@cratelyn
feat(mock-consensus): ➰ record height in inner span
4002dff 
this tweaks the fast-forward facilities (#3933, #4002) so that we record
the height as a span field per-loop iteration, not as a field in the
encompassing `#[instrument]` span.

see #4005 for an example of the misleading `height: 0` logs this would
generate.
@cratelyn cratelyn mentioned this issue Mar 15, 2024
Merged
cratelyn added a commit that referenced this issue Mar 15, 2024
@cratelyn
feat(mock-consensus): ➰ record height in inner span
fe81763 
this tweaks the fast-forward facilities (#3933, #4002) so that we record
the height as a span field per-loop iteration, not as a field in the
encompassing `#[instrument]` span.

see #4005 for an example of the misleading `height: 0` logs this would
generate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cratelyn cratelyn

Labels
A-mock-consensus Area: Relates to the mock consensus engine
Projects
Penumbra
Archived in project
Milestone
Sprint 2
Development

Successfully merging a pull request may close this issue.

mock-consensus: 🔀 test node can fast_forward penumbra-zone/penumbra
1 participant
@cratelyn