fix(proto): update DomainType::Proto
for ClientState/ConsensusState
#3529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug while testing the IBC implementation with Hermes. Previously it was writing an
Any
type to state at the client_state/consensus_state storage locations, but the type Hermes was expecting was theibc_proto
ClientState
/ConsensusState
. This resulted in a proto decoding error in these locations:https://github.com/informalsystems/hermes/blob/master/crates/relayer/src/client_state.rs#L127
https://github.com/informalsystems/hermes/blob/master/crates/relayer/src/consensus_state.rs#L59
These are called in the
Endpoint
query_client_state
/query_consensus_state
methods (for example here https://github.com/informalsystems/hermes/blob/b98ca86991fc1cc6d3f6c595918251a34eb6f1db/crates/relayer/src/chain/cosmos.rs#L1238)specifically the error I got from Hermes was
Error::decode_raw_client_state
:I can give more details on how I was running everything if needed!
also linted the protos cause CI complained 😭