Create a general convert circuit #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sounds like a French dish: "Le ConvertCircuit et ses contraintes"
Co-authored-by: redshiftzero <[email protected]>
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Failure
|
Should the |
This is a simple change that makes sense, imo, better to do now than have confusion later. |
7 tasks
conorsch
added a commit
that referenced
this pull request
Jan 3, 2024
Merged
conorsch
added a commit
that referenced
this pull request
Jan 4, 2024
conorsch
added a commit
that referenced
this pull request
Jan 5, 2024
Satisfies the latest cargo lints. I took the easy way out, preserving the existing function sigs, rather than performing a deeper refactor. Ignored the checks on the re-export of metrics code across components. Holding off on adding `--all-targets` to the check command, because there's some cleanup to do in the benchmarks, related to #3556. Revert "ci: disable -D warnings" This reverts commit 4e7c77b. Refs #3543.
conorsch
added a commit
that referenced
this pull request
Jan 5, 2024
Satisfies the latest cargo lints. I took the easy way out, preserving the existing function sigs, rather than performing a deeper refactor. Ignored the checks on the re-export of metrics code across components. Holding off on adding `--all-targets` to the check command, because there's some cleanup to do in the benchmarks, related to #3556. Revert "ci: disable -D warnings" This reverts commit 4e7c77b. Refs #3543.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3523.
This approach doesn't replace UndelegateClaimProof, but instead just changes the circuit that proof uses to be a more general one.