Add provenance tracking by sender address to SpendableNoteRecord.
#3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
This currently doesn't populate the data, it just makes it available in the protos. There's some work to be done on the Rust view server and in the web extension to populate this proto field with meaningful data.
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
aubrika
reviewed
Jan 9, 2024
| @@ -1683,7 +1691,7 @@ impl Storage { | |||
| spendable_notes.position | |||
| FROM notes | |||
| JOIN spendable_notes ON notes.note_commitment = spendable_notes.note_commitment | |||
| JOIN tx ON spendable_notes.source = tx.tx_hash | |||
| JOIN tx ON SUBSTR(spendable_notes.source, 5) = tx.tx_hash | |||
Merged
|
Superseded by #3604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the view service protos to include an optional
return_addressfor each note. This allows showing the provenance of individual notes.Also included is a terrifically ugly fix for #3568.