Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add proptests of first three circuits vs an in rust impl #3583

Merged
merged 4 commits into from
Jan 10, 2024
Merged

test: add proptests of first three circuits vs an in rust impl #3583

merged 4 commits into from
Jan 10, 2024

Conversation

redshiftzero
Copy link
Member

Three items towards #3564

cronokirby
cronokirby approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, these match the circuit from what I can tell, and the behavior makes sense.

One thing to think about is if we might have forgotten to check if something is not an identity point, but I think we've gotten that all.

@redshiftzero redshiftzero merged commit 28ee5f7 into main Jan 10, 2024
7 checks passed
@redshiftzero redshiftzero deleted the 3564-rustproof branch January 10, 2024 16:50
@redshiftzero redshiftzero mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cronokirby cronokirby cronokirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redshiftzero @cronokirby