ibc: ⛅ hoist ics02 validation out of client_counter #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nb: this commit strictly contains plain code motion. it does not make any changes to the code being moved. `ics02_validation` contains some important code for interfacing with tendermint/cometbft. while this submodule lives beneath the client counter logic, its contents are used in our message handling code related to e.g. misbehavior. this hoists this submodule up one level, to be a child of `penumbra_ibc::component`.
nb: this commit strictly contains plain code motion. it does not make any changes to the code being moved. while this was not originally placed in the ics02_validation submodule, it feels like it is more connected to that validation logic than the surrounding client counter types. this bears out to be true; it is `pub`, the client counter code isn't changed, and affected imports are in the message handler area.
cratelyn
force-pushed
the
katie/hoist-ics02-validation
branch
from
800434b
to
83f95f1
Compare
erwanor
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Did a review pass, and looks good to me. let's wait for @avahowell's +1 before merging
agree. this will conflict slightly with #3598, so do feel free to merge this on my behalf today 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nb: this branch strictly contains plain code motion. it does not make any
changes to the code being moved.
this branch performs two simple transformations, broken into two commits:
⛅ hoist ics02 validation out of client_counter
ics02_validationcontains some important code for interfacing withtendermint/cometbft. while this submodule lives beneath the client counter
logic, its contents are used in our message handling code related to e.g.
misbehavior.
this hoists this submodule up one level, to be a child of
penumbra_ibc::component.⛅ place
validate_penumbra_client_statein ics02_validationwhile validate_penumbra_client_state was not originally placed in the ics02_validation submodule,
it feels like it is more connected to that validation logic than the
surrounding client counter types.
this bears out to be true; it is
pub, the client counter code isn't changed,and affected imports are in the message handler area.