typo: PRF takes input 1 (not 0) when deriving nk
#3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One other minor comment on the spending key derivation document: The output of BIP-32 child key derivation is an integer mod n (i.e., a secp256k1 scalar), but the document treats this value as a 32-byte sequence, so it should explicitly define the way that it converts the integer to bytes. The code appears to treat the integer as big-endian bytes, which is consistent with BIP-32's (EDIT: apologies for adding this comment after the PR was already merged! If you think it makes sense to promote it to an issue, I've tried to put enough context in the comment that it's easy to do so.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick typo fix in docs (surmised based on the official implementation).