tests(app): 🐣 add stubs for mock consensus tests #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
C-enhancement
nb: this is strict code motion.
this introduces a small, failing test case that attempts to instantiate an app with a mock consensus engine. additional logic and other interfaces will be fleshed out in forthcoming commits.
when new versions of rust are released, there is a period before the new version appears in the overlay. this, in the worst case, can leave me (a foolish nix user) with a different toolchain than used in CI, with no way to easily rectify this. we could (should?) use a toolchain file, but i'm not going to introduce one purely for nix's sake. eugh.
cratelyn
force-pushed
the
katie/add-mock-consensus-test-stubs
branch
from
ab198e2
to
045e43c
Compare
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3588.
this paves the way for further work on the mock consensus engine. test facilities are moved around, app interfaces to be used by the mock engine are hoisted out into standalone crates, and a (failing) test is introduced.
i had to fix a feature flag while working on this related to governance/compact-block crates. that came from another PR, but i haven't bothered to diagnose which.