mock-consensus: 🙂 simplify test node startup #3849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is going to be repeated a lot, so let's put it in a helper function.
cratelyn
added
C-chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bit of polish for the mock consensus tests.
Consensusprovides itstower::Serviceimplementation viatower-actor, which makes naming aTestNode<_>slightly verbose. this introduces aConsensusServicetype alias, and outlines our test node startup into a shared function incommon.in the future we'll probably extend this
start_test_nodeto allow for callers to override particular settings on the test node builder. for now, that is elided. our primary goal is to provide an ergonomic "start a test node backed by temporary storage" button to reduce test boilerplate.Apptests #3588