Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(app): 🎤 uptime tracker tests for validators missing blocks #4061

Merged
merged 4 commits into from
Mar 21, 2024
Merged

tests(app): 🎤 uptime tracker tests for validators missing blocks #4061

merged 4 commits into from
Mar 21, 2024

Conversation

cratelyn
Copy link
Contributor

@cratelyn cratelyn commented Mar 20, 2024 •
edited
Loading

see #4040.

@cratelyn cratelyn mentioned this pull request Mar 20, 2024
Closed
26 tasks
@cratelyn cratelyn self-assigned this Mar 20, 2024
@cratelyn cratelyn added the A-mock-consensus Area: Relates to the mock consensus engine label Mar 20, 2024
@cratelyn cratelyn added this to the Sprint 2 milestone Mar 20, 2024
@cratelyn cratelyn force-pushed the kate/mock-consensus-validator-uptime branch from dd90d78 to 5d93d49 Compare March 20, 2024 21:37
@cratelyn cratelyn added the A-staking Area: Design and implementation of staking and delegation label Mar 20, 2024
@cratelyn cratelyn force-pushed the kate/mock-consensus-validator-uptime branch from 5d93d49 to ec1a8c7 Compare March 21, 2024 04:27
@cratelyn cratelyn changed the title tests(app): 🎤 add app_tracks_validator_uptimes test tests(app): 🎤 uptime tracker tests for validators missing blocks Mar 21, 2024
@cratelyn
chore(tests): 🙄 remove unused log_validator
8f54d7c
@cratelyn
feat(staking): 📐 Uptime::as_of_height() height accessor
8fae8e1 
for the sake of inspecting uptime state in tests, it would be nice for
us to be able to (immutably) see the `as_of_block_height` field.

this adds such an accessor to `penumbra_stake::Uptime`.
@cratelyn cratelyn force-pushed the kate/mock-consensus-validator-uptime branch from ec1a8c7 to 2e0889d Compare March 21, 2024 15:07
@cratelyn cratelyn marked this pull request as ready for review March 21, 2024 15:09
@cratelyn cratelyn force-pushed the kate/mock-consensus-validator-uptime branch from 2e0889d to 3fece33 Compare March 21, 2024 15:26
@cratelyn cratelyn merged commit 083beb0 into main Mar 21, 2024
6 checks passed
@cratelyn cratelyn deleted the kate/mock-consensus-validator-uptime branch March 21, 2024 15:58
This was referenced Mar 21, 2024
Closed
Closed
Merged
cratelyn added a commit that referenced this pull request Mar 26, 2024
@cratelyn
tests(app): 🧪 test that uptime tracks signed blocks (#4070)
c7c0223 
**NB:** this is based on #4099.

this adds test coverage, complementary to the work in #4061, which
asserts that we properly track the _affirmative_ case of validators
signing blocks.

fixes #4040. see #3995.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cratelyn cratelyn

Labels
A-mock-consensus Area: Relates to the mock consensus engine A-staking Area: Design and implementation of staking and delegation
Projects
Penumbra
Status: Done
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.
1 participant
@cratelyn