Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMake command to dev docs for linking against librocksdb #4725

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ejmg
Copy link
Collaborator

@ejmg ejmg commented Jul 18, 2024

In the current docs for linking against libsrockdb, building libsnappy.a will fail because of an error thrown while building its third party benchmarks which are enabled by default.

Describe your changes

This PR adds the CMake CLI option to the docs so that snappy's optional benchmarks are disabled by default.

Issue ticket number and link

NA

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

This is a one line change to developer docs for linking against a crate dependency.

…arks when linking against libsrockdb in dev docs.
@conorsch
Copy link
Contributor

Thanks for taking the time, @ejmg! Just-merged is a more comprehensive dev env in #4726, which should do the needful on setting up local tooling, regardless of your workstation platform.

@conorsch conorsch merged commit 5bc9346 into main Jul 22, 2024
9 checks passed
@conorsch conorsch deleted the fix-librocksdb-dev-doc branch July 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants