Make expert change #411
Merged
Make expert change #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way the duplication of filenames in the Makefile is reduced
maxnoe
reviewed
Sep 19, 2024
make/content/advanced.tex
Outdated
| report.txt: $(script_targets) #Variablen Verwendung | ||
| touch report.txt | ||
|
|
||
| $(script_targets): plot.py data.txt #Variablen Verwendung |
maxnoe
reviewed
Sep 19, 2024
make/content/advanced.tex
Outdated
| \begin{minted}{make} | ||
| all: report.txt | ||
|
|
||
| script_targets = plot1.pdf plot2.pdf plot3.pdf plot4.pdf plot5.pdf #Variablen Definition |
There was a problem hiding this comment.
Next step: plots = $(addprefix build/, $(addsuffix .pdf, plot1 plot2 plot3 plot4))
There was a problem hiding this comment.
I'm not opposed to add another slide for this to 👍
|
Side note, ubuntu 20.04 is a still supported LTS version and only has make 4.2 not sure we need to mention that though. |
chrbeckm
reviewed
Sep 20, 2024
make/content/advanced.tex
Outdated
| \begin{minted}{make} | ||
| all: report.txt | ||
|
|
||
| script_targets = plot1.pdf plot2.pdf plot3.pdf plot4.pdf plot5.pdf #Variablen Definition |
chrbeckm
reviewed
Sep 20, 2024
make/content/advanced.tex
Outdated
|
|
||
| script_targets = plot1.pdf plot2.pdf plot3.pdf plot4.pdf plot5.pdf #Variablen Definition | ||
|
|
||
| report.txt: $(script_targets) #Variablen Verwendung |
chrbeckm
reviewed
Sep 20, 2024
make/content/advanced.tex
Outdated
| report.txt: $(script_targets) #Variablen Verwendung | ||
| touch report.txt | ||
|
|
||
| $(script_targets): plot.py data.txt #Variablen Verwendung |
|
👍 |
maxnoe
reviewed
Sep 21, 2024
make/content/advanced.tex
Outdated
| all: report.txt | ||
|
|
||
| report.txt: plot1.pdf plot2.pdf | ||
| touch report.txt |
There was a problem hiding this comment.
Die Indentierung hier ist incosistent. Make braucht Tabs, keine spaces.
Vermutlich besser alle Beispiele als echte Makefiles, z.B. in examples/slideX.make zu speichern und inputminted zu behmen
…ia minted to the slides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we want to add this small change and example to the end of the expert slides:
Changes the solution for parallelization to using grouped targets.
Adds one slide with an example for make variables.
See #408 for details.
Personally I really do like this small addition and the look of the 'cleaner'
Makefile, but the change is not necessary.