-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPG-643: Fix stanza-upgrade after major upgrade #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
requested review from
tplavcic,
nmarukovich,
ptankov,
jvpasinatto,
eleo007,
hors,
inelpandzic and
pooknull
as code owners
September 25, 2024 15:37
hors
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@egegunes please check test
--- FAIL: TestReconcileStanzaCreate (0.52s)
helpers_test.go:180: Manager started
pgbackrest_test.go:764: assertion failed: expected error "fake stanza create failed: ", got "fake stanza create failed: "
fake stanza create failed:
github.com/percona/percona-postgresql-operator/internal/pgbackrest.Executor.StanzaCreateOrUpgrade
...
W0925 19:03:29.921842 18019 reflector.go:484] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:243: watch of *v1.Secret ended with: an error on the server ("unable to decode an event from the watch stream: context canceled") has prevented the request from succeeding
W0925 19:03:29.921911 18019 reflector.go:484] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:243: watch of *v1.StatefulSet ended with: an error on the server ("unable to decode an event from the watch stream: context canceled") has prevented the request from succeeding
FAIL
coverage: 77.7% of statements
FAIL github.com/percona/percona-postgresql-operator/internal/controller/postgrescluster 43.870s
and e2e major-upgrade test as well
commit: 4c4fa66 |
inelpandzic
approved these changes
Sep 26, 2024
hors
approved these changes
Sep 26, 2024
hors
pushed a commit
that referenced
this pull request
Sep 26, 2024
* K8SPG-643: Fix stanza-upgrade after major upgrade * fix test ¯\_(ツ)_/¯ * increase timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Operator first runs
stanza-create
and if it fails withbackup and archive info files exist but do not match the database
in the error, it runsstanza-upgrade
. The problem is operator tries to find this string inpgbackrest stanza-create
command's stderr but it's printed to stdout because of this commit in pgbackrest v2.53.Solution:
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability