Add proxy configuration to the transport #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AlekSi
approved these changes
Jun 1, 2020
|
@AlekSi Will there be any new release? |
|
Yepp, see #44 |
|
@ahmgeek v0.7.0 is tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If you run the exporter behind a proxy using
HTTPS_PROXY, the transport won't pick the environment variable. I think because it's not the default Transport.Here I am merely adding the configuration again, so it should be working as it is if you don't use any proxy and pick up the proxy if you are using it. Which we do in our case.