Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replicalag #51

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add replicalag #51

merged 1 commit into from
Sep 14, 2021

Conversation

blovett
Copy link

@blovett blovett commented Mar 5, 2021

This adds the ReplicaLag metric to the basic metric export.

To be honest, the conversion over to go mod probably isn't necessary here, except it made building this in an internal system so much easier.

@it-percona-cla
Copy link

it-percona-cla commented Mar 5, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@denisok denisok requested review from a team, askomorokhov and percona-csalguero and removed request for a team March 14, 2021 09:41
percona-csalguero
percona-csalguero previously approved these changes Mar 16, 2021
View reviewed changes
Copy link

@percona-csalguero percona-csalguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment. At line 252 it should be Unit in singular.

@blovett
Copy link
Author

blovett commented Mar 17, 2021

Just a small comment. At line 252 it should be Unit in singular.

Ok. I just went with what was overwhelmingly used in the other entries.

percona-csalguero
percona-csalguero previously approved these changes May 11, 2021
View reviewed changes
Copy link

@percona-csalguero percona-csalguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing but the same are failing in master branch

askomorokhov
askomorokhov previously approved these changes Jul 27, 2021
View reviewed changes
Copy link

@askomorokhov askomorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me 👍

@denisok
Copy link

denisok commented Aug 11, 2021

@blovett could you please resolve conflicts and we are going to merge this

@vlinevych
Copy link

@blovett thanks for your contribution, I am highly interested in this feature.
Would you mind pulling the master into your branch so the conflict is resolved?

Otherwise I could just cherry-pick your changes and open a new PR.

@blovett
Copy link
Author

blovett commented Sep 7, 2021

rebased against master. thanks!

@denisok denisok requested review from a team and JiriCtvrtka and removed request for a team September 7, 2021 12:59
@denisok
Copy link

denisok commented Sep 14, 2021

@JiriCtvrtka should we just merge this ?

@JiriCtvrtka
Copy link

@denisok Tests on local env passed without error, so yes we can.

@denisok denisok merged commit afae98f into percona:master Sep 14, 2021
@percona-csalguero percona-csalguero mentioned this pull request Oct 4, 2021
Closed
@denisok denisok added the award swag prize for the contributors. Please contact Percona if we can't reach you! label Dec 1, 2021
@Aleksa-del
Copy link

@blovett Hello! We would love to send you a gift from Percona for your contribution. Please, contact us at [email protected]

@blovett blovett deleted the add_replicalag branch December 3, 2021 22:39
mprokopov pushed a commit to ozean12/rds_exporter that referenced this pull request Jul 9, 2024
@blovett @mprokopov
add the ReplicaLag metric (percona#51)
76a1e3d
mprokopov added a commit to ozean12/rds_exporter that referenced this pull request Jul 9, 2024
@mprokopov @EduSemensati
@askomorokhov @yareach @AlekSi @vlinevych @denisok @percona-csalguero @BupycHuk @blovett @rnovikovP @nikita-b @yonahd @maxknee @JiriCtvrtka @cezmunsta @YaroslavPodorvanov @artemgavrilov @pkadej @dbazhenov
PENG-2776: Bump RDS Exporter (#6)
940bc79 
* Create rds_exporter-component.yaml

* PMM-6120 Use go 1.14 (percona#45)

* PMM-6213 Remove go 1.13 from travis. (percona#46)

* PMM-6213 Remove go 1.13 from travis.

* PMM-6213 Add go 1.15.x

* PMM-6213 Add go tip.

* PMM-6756 Added go 1.15.x. (percona#48)

* [PMM-6756] Added go 1.15.x.

* PMM-6756 Update

* PMM-6756 Update

* PMM-6756 Revert

* Dummy

* PMM-6756 Update golden files

Co-authored-by: Andrii Skomorokhov <[email protected]>
Co-authored-by: Alexey Palazhchenko <[email protected]>

* Overcome the limitation of 100 dbinstances (percona#47)

* ci: rotate integration keys (percona#52)

* Delete .travis.yml

* PMM-7602 Add GitHub Action (percona#53)

* PMM-7602 Add GitHub Action

* PMM-7602 Point actions to forked repo.

* PMM-7602 Removed travis.

* PMM-7602 Use go modules.

* PMM-7602 Fix check.

* PMM-7602 Fix mod.

* PMM-7602 Fix setup.

* PMM-7602 Fix setup.

* PMM-7602 Fix setup.

* add environment

* PMM-7602 Fix tests.

* PMM-7602 Fix codecov

* PMM-7602 defines what to use go get or go install

* PMM-7602 Improve go get/install

* PMM-7602 Improve get promu.

* PMM-7602 Use tools module for tooling.

* PMM-7602 Fix mods.

* PMM-7602 Fix path

* PMM-7602 Fix gocoverutil

Co-authored-by: Denys Kondratenko <[email protected]>

* PPMM-7961 Updated exporter_shared (percona#59)

* PMM-7902 Remove Go 1.15 (percona#60)

* Add docker multistage build (percona#61)

* bring back maxInterval=60 sec (percona#63)

Co-authored-by: Volodymyr Linevych <[email protected]>
Co-authored-by: Volodymyr Linevych <[email protected]>

* PMM-8207 Cleanup. (percona#57)

Co-authored-by: Jiri Ctvrtka <[email protected]>

* add the ReplicaLag metric (percona#51)

* Update README.md (percona#65)

Remove mentioning upstream as we reworked the project entirely. This statement can confuse people

* PMM-6013 change default branch to main (percona#67)

* Support assume role (percona#70)

* assume role

* move credentials into session

* adding .goreleaser.yml (percona#72)

* adding .goreleaser.yml

Signed-off-by: Max Knee <[email protected]>

* adding new line

Signed-off-by: Max Knee <[email protected]>

* Apply suggestions from code review

Co-authored-by: Denys Kondratenko <[email protected]>

* Update .goreleaser.yml

* adding releaser action

Signed-off-by: Max Knee <[email protected]>

* Update release.yml

* Update .goreleaser.yml

* maxknee test docker build

Signed-off-by: Max Knee <[email protected]>

* adding go 1.16

Signed-off-by: Max Knee <[email protected]>

* debugging action

Signed-off-by: Max Knee <[email protected]>

* updating dockerfile

Signed-off-by: Max Knee <[email protected]>

* reverting docker file and adding new releaserfile

Signed-off-by: Max Knee <[email protected]>

Co-authored-by: Denys Kondratenko <[email protected]>

* Update Dockerfile.releaser

* Update .goreleaser.yml

* Update .goreleaser.yml

* Update release.yml

* Update release.yml

* cost exclaimer  (percona#73)

* cost exclaimer and docker push

* Update Makefile

Remove change of makefile

* PMM-9337 Update go 1.17 (percona#77)

* PMM-9337 Update go 1.17

* Fix codecov

Co-authored-by: JiriCtvrtka <[email protected]>

* Fix incorrect version (percona#76)

* Fix incorrect version.

* FIx for releaser itself.

* Removing promu.

* Delete another file related to promu.

* update ldflags

update ldflags to fill correct values for version

* Remove make build.

* Tidy.

* Revert "Tidy."

This reverts commit 472ca26.

* add prometheus again

* add required packages

* Remove make tarball from CI.

* Remove make tarball

* trigger

Co-authored-by: Denys Kondratenko <[email protected]>

* PMM-11049 Typo present in enhanced metrics scraper for rds_exporter (percona#82)

Co-authored-by: cezmunsta <[email protected]>

* PMM-11312 --version (percona#84)

* PMM-11312 --version

* PMM-11312 make feature-build

* PMM-11312 newline

* PMM-11312 rename command

* PMM-11312 just update version

* PMM-7 Add dependabot (percona#85)

* PMM-11497 Update dependencies. (percona#87)

* PMM-11632 rds_exporter ignores DisableEnhancedMetrics (percona#91)

* Discord link has been removed (percona#92)

* PMM-12339 remove go tip (percona#94)

* PMM-12339 remove go tip

PMM-12339

https://goreleaser.com/deprecations/?h=rm+dist#-rm-dist

* PMM-12339 refactor go workflow

* PMM-12339 Hix CI

* PMM-12339 avoid triggering tests twice

---------

Co-authored-by: Artem Gavrilov <[email protected]>

* Rename build to builder

* golang 1.19

* Patch dist

---------

Co-authored-by: Eduardo Rodrigues Semensati <[email protected]>
Co-authored-by: Andrii Skomorokhov <[email protected]>
Co-authored-by: Jaroslav Musil <[email protected]>
Co-authored-by: Andrii Skomorokhov <[email protected]>
Co-authored-by: Alexey Palazhchenko <[email protected]>
Co-authored-by: Volodymyr Linevych <[email protected]>
Co-authored-by: Alex Tymchuk <[email protected]>
Co-authored-by: Denys Kondratenko <[email protected]>
Co-authored-by: Carlos Salguero <[email protected]>
Co-authored-by: Nurlan Moldomurov <[email protected]>
Co-authored-by: Volodymyr Linevych <[email protected]>
Co-authored-by: Jiri Ctvrtka <[email protected]>
Co-authored-by: ben lovett <[email protected]>
Co-authored-by: Roma Novikov <[email protected]>
Co-authored-by: Nikita Beletskii <[email protected]>
Co-authored-by: Yonah Dissen <[email protected]>
Co-authored-by: Max Knee <[email protected]>
Co-authored-by: JiriCtvrtka <[email protected]>
Co-authored-by: cezmunsta <[email protected]>
Co-authored-by: Yaroslav Podorvanov <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
Co-authored-by: Przemyslaw Kadej <[email protected]>
Co-authored-by: Daniil Bazhenov <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiriCtvrtka JiriCtvrtka JiriCtvrtka approved these changes

@percona-csalguero percona-csalguero percona-csalguero approved these changes

@BupycHuk BupycHuk BupycHuk approved these changes

@askomorokhov askomorokhov askomorokhov left review comments

Assignees

@percona-csalguero percona-csalguero

Labels
award swag prize for the contributors. Please contact Percona if we can't reach you! community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@blovett @it-percona-cla @denisok @vlinevych @JiriCtvrtka @Aleksa-del @BupycHuk @askomorokhov @percona-csalguero