Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toString PID number for writeFileSync (second arg requires string) #573

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

Robdel12
Copy link
Contributor

What is this?

Node 14 will no longer coerce incorrect types given to writeFileSync.

image

The error thrown:

TypeError: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received type number

…tring)

Node 14 will no longer coerce incorrect types given to `writeFileSync`.

The error thrown:

```
TypeError: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received type number
```
Copy link
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮

@Robdel12 Robdel12 merged commit 7207af1 into master Oct 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the rd/fix-node-14-detached branch October 14, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants