add wdio support for ts #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this-is-shivamsingh
requested review from
a team,
yashdsaraf,
Amit3200 and
chinmay-browserstack
and removed request for
a team
percy/driver/driverWrapper.js
Outdated
| this.type = 'wdio'; | ||
| } else if ((driver.constructor.name === '' || | ||
| driver.constructor.name === 'Object') && // Object check is only added for tests | ||
| driver.constructor.name.includes('Object')) && // Object check is only added for tests |
There was a problem hiding this comment.
Something looks incorrect here.
There was a problem hiding this comment.
@Amit3200 a similar fix for the issue can be seen in: percy/percy-selenium-js#406
There was a problem hiding this comment.
@chinmay-browserstack resolved
|
Update description as well. |
chinmay-browserstack
previously approved these changes
Nov 3, 2023
Amit3200
previously approved these changes
Nov 3, 2023
prklm10
reviewed
Nov 3, 2023
this-is-shivamsingh
dismissed stale reviews from Amit3200 and chinmay-browserstack
via
d3b99da
prklm10
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing SDK is not working on windows with ts the reason for same class name of wdio driver is
BoundBrowserinstead ofBrowserwhich we check.