Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cu): indicate to loader whether or not to apply metering #1040

Closed
TillaTheHun0 opened this issue Oct 15, 2024 · 0 comments · Fixed by #1042
Closed

feat(cu): indicate to loader whether or not to apply metering #1040

TillaTheHun0 opened this issue Oct 15, 2024 · 0 comments · Fixed by #1042
Assignees
@TillaTheHun0
Labels
cu ao Compute Unit

Comments

@TillaTheHun0
Copy link
Member

Background

AoLoader overloads WebAssembly.compile and WebAssembly.compileStreaming in order to apply metering to wasm binaries. This is activated via passing a applyMetering flag in the importObject

Problem

The CU currently does not pass this flag

Solution

Add an environment variable to the CU to enable/disable metering. It should default to enabled.
@TillaTheHun0 TillaTheHun0 added the cu ao Compute Unit label Oct 15, 2024
@TillaTheHun0 TillaTheHun0 self-assigned this Oct 15, 2024
@PeterFarber PeterFarber mentioned this issue Oct 15, 2024
Merged
TillaTheHun0 added a commit that referenced this issue Oct 15, 2024
@TillaTheHun0
feat(cu): add flag to disable/enable wasm metering and apply #1040
c3f24c1
@TillaTheHun0 TillaTheHun0 mentioned this issue Oct 15, 2024
Merged
PeterFarber added a commit that referenced this issue Oct 15, 2024
@PeterFarber
chore(loader): introduced an argument to determine if metering is app…
b61c727 
…lied #1040
TillaTheHun0 added a commit that referenced this issue Oct 15, 2024
@TillaTheHun0
feat(cu): add flag to disable/enable wasm metering and apply #1040
4fdcbc4
PeterFarber added a commit that referenced this issue Oct 16, 2024
@PeterFarber
chore(loader): introduced an argument to determine if metering is app…
c8d8333 
…lied #1040
PeterFarber added a commit that referenced this issue Oct 16, 2024
@PeterFarber
chore(loader): introduced an argument to determine if metering is app…
4989613 
…lied #1040
@PeterFarber PeterFarber mentioned this issue Oct 16, 2024
Closed
TillaTheHun0 added a commit that referenced this issue Oct 16, 2024
@TillaTheHun0
feat(cu): remove metering flag, as this is instead controlled by modu…
45348df 
…le format in ao loader #1040

This reverts commit 4fdcbc4.
TillaTheHun0 added a commit that referenced this issue Oct 16, 2024
@TillaTheHun0
feat(cu): remove metering flag, as this is instead controlled by modu…
82658f4 
…le format in ao loader #1040

This reverts commit 4fdcbc4.
TillaTheHun0 added a commit that referenced this issue Oct 16, 2024
@TillaTheHun0
chore(cu): bump ao-loader to latest #1040
096c507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TillaTheHun0 TillaTheHun0

Labels
cu ao Compute Unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cu): add flag to disable/enable wasm metering and apply #1040 permaweb/ao
1 participant
@TillaTheHun0