perf(loader): manually deregister listeners setup by loader to prevent memory leaks #167 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167
There is an open issue in emscripten that it causes memory leaks on WASM that is loaded multiple times. This is due to event listeners that are created that reference the 16MB memory allocation set up for the WASM, and are never deregistered. Because the listeners are never deregistered, the 16MB can never be garbage collected, which will eventually cause node to run out of memory.
This PR adds a utility to the loader that tracks listeners created as part of the WASM, and deregisters them once the invocation is complete.