fix(types): correct types for quota bytes #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/props
branch
2 times, most recently
from
f37a792
to
1d9f2d9
Compare
perry-mitchell
requested changes
Aug 2, 2024
susnux
commented
Aug 2, 2024
As per RFC the value shall be octets representing the quota, in all cases I know the value will be parsed to `number` by the XML parser. (tested e.g. with Sabre / Nextcloud). Signed-off-by: Ferdinand Thiessen <[email protected]>
perry-mitchell
approved these changes
Aug 2, 2024
|
Thanks @susnux ! Will push a release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RFC the value shall be octets representing the quota, in all cases I know the value will be parsed to
numberby the XML parser. (tested e.g. with Sabre / Nextcloud).While
anyallowed everything, the typestringfor quota-used-bytes was wrong as mostly a number is returned (but there might be rare cases of string, like "unlimited" (even if the RFC does not mention this), so lets keep thestringtype in addition.