Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS2 CI and Black Formatting for Python Nodes #32

Open
amalnanavati opened this issue May 4, 2023 · 1 comment
Open

Add ROS2 CI and Black Formatting for Python Nodes #32

amalnanavati opened this issue May 4, 2023 · 1 comment
Labels
dev-process Issues related to continuous integration, dependencies, etc.

Comments

@amalnanavati
Copy link
Contributor

Since this repository has a few ROS2 nodes and some Python code, we should add CI that ensures the ROS2 nodes all compile and that the Python code is formatted (I'd suggest using the black formatter.

This is not critical path, since the ROS2 nodes in this repository are only for testing the web app. But it is nice-to-have.

@amalnanavati amalnanavati changed the title Add ROS2 CI and Black Formatting (Python) Add ROS2 CI and Black Formatting for Python Nodes May 4, 2023
@amalnanavati
Copy link
Contributor Author

Also, if/when ROS2 CI and black formatting becomes an explicit part of the checks that must pass before merging, we should add documentation on how to run black formatter locally and how the CI ROS tests locally.

@amalnanavati amalnanavati added the dev-process Issues related to continuous integration, dependencies, etc. label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-process Issues related to continuous integration, dependencies, etc.
Projects
None yet
Development

No branches or pull requests

1 participant