Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile pt. 2 #124

Merged
merged 13 commits into from
Jul 10, 2021
Merged

Add Dockerfile pt. 2 #124

merged 13 commits into from
Jul 10, 2021

Commits on Jul 5, 2021

  1. add Dockerfile with instructions in README

    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    8f840da View commit details
    Browse the repository at this point in the history

  2. dockerfile - use local dir for build, set all envs 

     - instead of go-getting from GitHub, the binary is built from the
   source directory (assumed to be in the same directory as the
   Dockerfile)
 - set all `HOST_` required by gopsutil
 - alternatively, for faster development you can uncomment out the
   `# ADD grofer /go/bin/` to directly add the local `grofer` binary
   instead of building it inside the container everytime.

   If you see a GLIBC error on running the binary in the container,
   build it with `CGO_ENABLED=0 go build`
    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    3bf5b5d View commit details
    Browse the repository at this point in the history

  3. dockerfile - update README to use /host instead of /rootfs 

    the `HOST_` env vars are set to `/host` and not `/rootfs`, obviously
that should not have worked lol
    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    3788593 View commit details
    Browse the repository at this point in the history

  4. dockerfile - run with --privileged and --pid=host

    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    22aa45b View commit details
    Browse the repository at this point in the history

  5. dockerfile - switch to alpine from deb-buster

    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    2534a00 View commit details
    Browse the repository at this point in the history

  6. dockerfile - add --network=host flag 

    this fixes wrong network stats issue
    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    d6dbda3 View commit details
    Browse the repository at this point in the history

  7. dockerfile - update comments

    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    59ee9bc View commit details
    Browse the repository at this point in the history

  8. dockerfile - add action to build and pub image 

     - publishes image to the GitHub docker registry
   (NOT GitHub container registry)
 - temporarily also includes containers for all PRs
    - this is only to test this in the PR
    - will be disabled in a later commit
 - testing with act fails due to the registry
   login step
    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    d979331 View commit details
    Browse the repository at this point in the history

  9. dockerfile - ghcr.io based workflow to publish img 

     - moved to the GitHub container registry since it supersedes
   the GitHub docker registry
 - act still fails, need to try on actual actions
    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    3099de3 View commit details
    Browse the repository at this point in the history

  10. dockerfile - add docker socket volume to instrs

    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    d5ad744 View commit details
    Browse the repository at this point in the history

  11. dockerfile - readme points to ghcr.io/pesos/grofer

    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    14c9d7e View commit details
    Browse the repository at this point in the history

  12. dockerfile - disable docker workflow on PRs 

     - this was only enabled for testing
 - it does not currently work for PRs that originate from forks
    - i.e., only internal branches work
 - commented it out in case it is needed later
    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    32d7331 View commit details
    Browse the repository at this point in the history

  13. dockerfile (#124) - mention docker tags in README

    @Samyak2
    Samyak2 committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    3c3ddaf View commit details
    Browse the repository at this point in the history