-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read properties of undefined (reading 'number') #2790
Cannot read properties of undefined (reading 'number') #2790
Comments
Same here, starting happening a few hours ago |
I've not made any changes to the action since releasing Reproduced the problem with my test suite. I'll make a GitHub support ticket. |
Created a GitHub support ticket for this issue. Thanks for reporting it. |
I'm trying to confirm with GitHub support, but it looks like there was a bug with GitHub's list pull requests API that just got fixed. It appears I was unknowingly working around this bug for about 2 years! In fixing it they've caused a breaking change. |
Released Please note that I'm assuming that GitHub are not going to roll this change back. 😓 I'm trying to confirm with GitHub support that it was actually a long standing bug that just got fixed. |
Need an update to create-pull-request@v6 to fix [an issue with the GitHub API](peter-evans/create-pull-request#2790).
Need an update to create-pull-request@v6 to fix [an issue with the GitHub API](peter-evans/create-pull-request#2790).
GitHub support have confirmed that an intentional change was made to the list API, and the fix they suggested to me (released as |
We're encountering this bug: peter-evans/create-pull-request#2790 Updating to v6.0.1 should fix the issue.
This fix a [bug](peter-evans/create-pull-request#2790) that occurs on PR creation when the "same" pull request already exist.
Due to another issue preventing some users from being able to use |
Apparently following #704, projen stopped getting upgrades. We missed a fairly important update that bumps github action versions and fixes peter-evans/create-pull-request#2790
Pull in the fix for peter-evans/create-pull-request#2790
This version has a fix for the error we encounter when this workflow is ran: peter-evans/create-pull-request#2790
This version has a fix for the error we encounter when this workflow is ran: peter-evans/create-pull-request#2790
This PR bumps the version of peter-evans/create-pull-request to v6 to address this [issue](peter-evans/create-pull-request#2790)
Should fix random > Cannot read properties of undefined (reading 'number') errors in update asdf actions, tested with internal service to work Source for the idea: peter-evans/create-pull-request#2790
Subject of the issue
I started getting this error on v4, so upgraded to v6, but I'm still seeing it 🤔
Seems to only happen when there's an existing pull request, if I delete the existing one the workflow will succeed.
Steps to reproduce
Run the workflow with an existing pull request present.
https://github.com/stevelacey/release-builder/blob/v1/pull-request/action.yml#L27C25-L39
The text was updated successfully, but these errors were encountered: