Decode SAMLResponse and SAMLRequest as UTF-8 strings #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into encoding problems when decoding SAML messages from FEIDE. It turned out that UTF-8 characters were converted into ASCII such that e.g. "ø" became "C8". This patch solves the problem.
The SAML standard states: "The character set of the XML document resulting from decoding the data is determined in the normal fashion, and defaults to UTF-8 if no character set is indicated."
To support encodings other than UTF-8 more work is needed, but I'd suggest using UTF-8 instead of ASCII.