Make a breaking change

Signed-off-by: Peter Nied <[email protected]>
peternied · Mar 29, 2024 · c8bc3bd · c8bc3bd
1 parent 6ce041e
commit c8bc3bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/server/src/main/java/org/opensearch/plugins/Plugin.java b/server/src/main/java/org/opensearch/plugins/Plugin.java
@@ -104,12 +104,12 @@ protected Optional<String> getFeature() {
         return Optional.empty();
     }
 
-    /**
-     * Node level guice modules.
-     */
-    public Collection<Module> createGuiceModules() {
-        return Collections.emptyList();
-    }
+    // /**
+    //  * Node level guice modules.
+    //  */
+    // public Collection<Module> createGuiceModules() {
+    //     return Collections.emptyList();
+    // }
 
     /**
      * Node level services that will be automatically started/stopped/closed. This classes must be constructed

diff --git a/server/src/main/java/org/opensearch/plugins/PluginsService.java b/server/src/main/java/org/opensearch/plugins/PluginsService.java
@@ -283,7 +283,7 @@ public Settings updatedSettings() {
     public Collection<Module> createGuiceModules() {
         List<Module> modules = new ArrayList<>();
         for (Tuple<PluginInfo, Plugin> plugin : plugins) {
-            modules.addAll(plugin.v2().createGuiceModules());
+//            modules.addAll(plugin.v2().createGuiceModules());
         }
         return modules;
     }