Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Serde implementation #99

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Fix Serde implementation #99

merged 8 commits into from
Feb 26, 2024

Conversation

james7132
Copy link
Collaborator

Since #74, the serde implementation has been platform dependent due to the use of usize as the inner block.

This PR fixes that by providing a platform agnostic manual serde implementation by converting blocks to a fixed little-endian representation, then serializing the entire byte buffer. Unfortunately this involves allocation during serialization, but it's preferable to having serde broken when moving from platform to platform.

This is a breaking change and existing instances of the serialized bitset will be broken.

@james7132 james7132 merged commit fab28de into petgraph:master Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant