add isCancelled() regression tests #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
approved these changes
Sep 19, 2016
| }); | ||
|
|
||
| specify("isCancelled() synchronously returns true after calling cancel() on pending promise", function() { | ||
| var resolver = Promise.pending(); |
There was a problem hiding this comment.
Let's not use Promise.pending in new tests?
There was a problem hiding this comment.
I'm happy to clean this up. What should it be replaced with?
There was a problem hiding this comment.
I think new Promise(function(){}) works fine.
| }); | ||
|
|
||
| specify("isCancelled() synchronously returns true after calling cancel() on promise created from .then()", function() { | ||
| var resolver = Promise.pending(); |
There was a problem hiding this comment.
Same, let's not use Promise.pending in new tests
|
Feedback addressed. |
|
@benjamingr Does this look ok to merge? |
|
@benjamingr @petkaantonov ping :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some regression tests around isCancelled(). These tests are green against bluebird master:
In our fork of bluebird, we moved over from bluebird2 to bluebird3 a few months ago so we're on a slightly older version of bluebird still. We have some issues with this version around cancellation, and the second unit test here isolates one of these issues - it fails in our fork:
Looks like we can merge the latest release of bluebird to fix the issue on our side. Adding these tests to protect this behavior.