-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pex fails to consistently use https_proxy + --cert #1058
Comments
An extra confusing variable is that when REQUESTS_CA_BUNDLE is exported instead of passing --cert, then both black and setuptools are looked up and downloaded successfully through the proxy. |
Ok, this is a bug in Pip PEP-517 handling. Notice: In other words, black uses pyproject.toml and specifies a custom builder: [build-system]
requires = ["setuptools>=41.0", "setuptools-scm", "wheel"]
build-backend = "setuptools.build_meta" Its the execution of the custom builder that fails here in the prerequisite step of downloading its requirements. That seems to point to Pip not propagating its |
And the Pip issue is here: pypa/pip#5502 |
OK, and it looks like we can convert --cert into a PIP_CERT env var to solve this: pypa/pip#5502 (comment) |
Currently we set up The assumption in that method is CLI args are returned based on network configuration. We'll probably need to split that method into |
Previously `--cert` did not propagate correctly through Pip. Work around this by passing the option via environment variable. Fixes pex-tool#1058
As noted in #1060 this is still not completely fixed. |
In order to work around pypa/pip#5502 fully, we extract a `PackageIndexConfiguration` class that handles arrangement of Pip command line flags and enviornment variables to effect the most hermetic means possible of conveying `--cert` and `--client-cert` to Pip and its subprocesses. Fixes pex-tool#1058
In order to work around pypa/pip#5502 fully, we extract a `PackageIndexConfiguration` class that handles arrangement of Pip command line flags and enviornment variables to effect the most hermetic means possible of conveying `--cert` and `--client-cert` to Pip and its subprocesses. Fixes #1058
No self-contained repro yet, but a user reports the following:
In a container where the ambient REQUESTS_CA_BUNDLE points to a host-system self-signed cert authority:
Note that black is successfully lokked up and downloaded through the proxy on pypi, but then setuptools fails the same sequence immediately after.
The text was updated successfully, but these errors were encountered: