Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent PEP-517 failures. #2540

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Commits on Sep 19, 2024

  1. Fix intermittent PEP-517 failures.

    I've not had a report in the wild, but CI intermittently fails in
    PEP-517 tests, not finding the json communication file on the read end.
    This exposes a race where the PEP-517 process completes before the
    temporary file context manager is exited and the communication file,
    with the results therein, is deleted before it can be read. Switch from
    a temporary file that deletes on context exit (it's amazing this worked
    as reliably as it did - it was a bug from day 1!) to one that deletes
    only upon the Pex process exit.
    jsirois committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    251ebcc View commit details
    Browse the repository at this point in the history