Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair style issues in master. #464

Merged
merged 1 commit into from
May 11, 2018
Merged

Conversation

kwlzn
Copy link
Contributor

@kwlzn kwlzn commented May 11, 2018

before:

[omerta pex2 (master)]$ tox -e style
GLOB sdist-make: /Users/kwilson/dev/pex2/setup.py
style create: /Users/kwilson/dev/pex2/.tox/style
style installdeps: twitter.checkstyle
style inst: /Users/kwilson/dev/pex2/.tox/dist/pex-1.3.2.zip
style installed: gitdb==0.6.4,GitPython==0.3.2rc1,pep8==1.4.5,pex==1.3.2,pyflakes==0.7.2,smmap==0.9.0,twitter.checkstyle==0.1.0,twitter.common.app==0.3.0,twitter.common.collections==0.3.0,twitter.common.contextutil==0.3.0,twitter.common.dirutil==0.3.0,twitter.common.lang==0.3.0,twitter.common.log==0.3.0,twitter.common.options==0.3.0,twitter.common.process==0.3.0,twitter.common.string==0.3.0,twitter.common.util==0.3.0
style runtests: PYTHONHASHSEED='3976592587'
style runtests: commands[0] | twitterstyle -n ImportOrder /Users/kwilson/dev/pex2/pex /Users/kwilson/dev/pex2/tests
T302:ERROR   /Users/kwilson/dev/pex2/tests/test_integration.py:659 Expected 2 blank lines, found 1
     |def test_inherit_path_fallback():

T302:ERROR   /Users/kwilson/dev/pex2/tests/test_integration.py:662 Expected 2 blank lines, found 1
     |def test_inherit_path_backwards_compatibility():

T302:ERROR   /Users/kwilson/dev/pex2/tests/test_integration.py:665 Expected 2 blank lines, found 1
     |def test_inherit_path_prefer():

T302:ERROR   /Users/kwilson/dev/pex2/tests/test_integration.py:668 Expected 2 blank lines, found 1
     |def inherit_path(inherit_path):

F401:ERROR   /Users/kwilson/dev/pex2/tests/test_resolver.py:005 'sys' imported but unused
     |import sys

F401:ERROR   /Users/kwilson/dev/pex2/tests/test_resolver.py:015 'PythonInterpreter' imported but unused
     |from pex.interpreter import PythonInterpreter

ERROR: InvocationError: '/Users/kwilson/dev/pex2/.tox/style/bin/twitterstyle -n ImportOrder /Users/kwilson/dev/pex2/pex /Users/kwilson/dev/pex2/tests'
_______________________________________________________ summary ________________________________________________________
ERROR:   style: commands failed

after:

[omerta pex2 (kwlzn/style_fixes)]$ tox -e style
GLOB sdist-make: /Users/kwilson/dev/pex2/setup.py
style inst-nodeps: /Users/kwilson/dev/pex2/.tox/dist/pex-1.3.2.zip
style installed: gitdb==0.6.4,GitPython==0.3.2rc1,pep8==1.4.5,pex==1.3.2,pyflakes==0.7.2,smmap==0.9.0,twitter.checkstyle==0.1.0,twitter.common.app==0.3.0,twitter.common.collections==0.3.0,twitter.common.contextutil==0.3.0,twitter.common.dirutil==0.3.0,twitter.common.lang==0.3.0,twitter.common.log==0.3.0,twitter.common.options==0.3.0,twitter.common.process==0.3.0,twitter.common.string==0.3.0,twitter.common.util==0.3.0
style runtests: PYTHONHASHSEED='3671025614'
style runtests: commands[0] | twitterstyle -n ImportOrder /Users/kwilson/dev/pex2/pex /Users/kwilson/dev/pex2/tests
_______________________________________________________ summary ________________________________________________________
  style: commands succeeded
  congratulations :)

@kwlzn
Copy link
Contributor Author

kwlzn commented May 11, 2018

will TBR this once the style shard goes green in my fork.

@kwlzn kwlzn merged commit ca2a8c4 into pex-tool:master May 11, 2018
@kwlzn kwlzn mentioned this pull request May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant