Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump travis image to Trusty. #476

Merged
merged 1 commit into from
May 14, 2018
Merged

Bump travis image to Trusty. #476

merged 1 commit into from
May 14, 2018

Conversation

kwlzn
Copy link
Contributor

@kwlzn kwlzn commented May 14, 2018

No description provided.

@kwlzn
Copy link
Contributor Author

kwlzn commented May 14, 2018

will TBR on greenish CI.

@kwlzn kwlzn requested a review from CMLivingston May 14, 2018 21:05
CMLivingston
CMLivingston approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@CMLivingston CMLivingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we don't care about that comment regarding "too many open files". Based on my browsing of github issues related to the pypy shard issues, this seems to be the fix.

@kwlzn kwlzn merged commit 0ada560 into pex-tool:master May 14, 2018
@kwlzn
Copy link
Contributor Author

kwlzn commented May 15, 2018

hmm, I didn't see the "too many open files" thing in several CI runs - then just started seeing it last night. more work to be done there, I guess.

@kwlzn kwlzn mentioned this pull request May 15, 2018
Closed
@kwlzn kwlzn mentioned this pull request May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CMLivingston CMLivingston CMLivingston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwlzn @CMLivingston