Handle dlopen(NULL) failure in glibc fallback #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pradyun Gedam <[email protected]>
This is needed to maintain Python 2.7 support.
|
@benjyw I'm going to submit this TBR, which is safe, since Pex pins to the prior tip sha of this patches branch. There will be a separate PR coming from Pex to bump to this sha to supprt musl libc static Pythons, like those PBS ships. |
This was referenced Jul 23, 2024
jsirois
added a commit
to pex-tool/pex
that referenced
this pull request
Jul 24, 2024
This pulls in a new vendored version of Pip with the recent fix in pypa/pip#12716 applied in pex-tool/pip#13. As a result, Pex can run using vendored Pip under statically linked musl libc CPython interpreters. This opens the door to bootstrapping newer unpatched Pip's that also have this same fix (versions 24.2 and later; see: #2471). Fixes #2017
SG. I'm back from Europe now, so will be more available for reviews, and at normal hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 601bcf8)
Manually removed type annotation added in that commit to keep Python 2.7
support for Pex vendored Pip.
Co-authored-by: Pradyun Gedam [email protected]