Fix download --constraint for legacy-resolver. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download was not filtering out constraint-only requirements prior to attempting to save them. Add a failing test under `--resolver=legacy` and fix by adding in the filtering. See: pypa@b28e2c4#r45135982 Fixes pypa#9283
|
See pypa#9283, but Pip master has a bug handling the download command when --constraint is used (this is the way Pants uses Pex and thus Pip). Although I have pypa#9301 away with this same patch it seems unlikely to be accepted and released in a tight enough time frame to provide our macOS BigSur users timely relief. As such, I've created the pex/patches/generation-2 branch which is up to date with Pip master to use as a new branch for Pex to vendor from. |
stuhood
approved these changes
Dec 15, 2020
jsirois
added a commit
that referenced
this pull request
Feb 1, 2021
Download was not filtering out constraint-only requirements prior to attempting to save them. Add a failing test under `--resolver=legacy` and fix by adding in the filtering. See: pypa@b28e2c4#r45135982 Fixes pypa#9283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download was not filtering out constraint-only requirements prior to
attempting to save them. Add a failing test under
--resolver=legacyand fix by adding in the filtering.
See: pypa@b28e2c4#r45135982
Fixes pypa#9283