BamWriter: use sizeof(uint32_t) increment to swap bytes for big endia…

…n architectures. Closes: #236
pezmaster31 · Jul 12, 2024 · 1ce1d52 · 1ce1d52
1 parent 46ed2fc
commit 1ce1d52
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/api/internal/bam/BamWriter_p.cpp b/src/api/internal/bam/BamWriter_p.cpp
@@ -349,7 +349,7 @@ void BamWriterPrivate::WriteAlignment(const BamAlignment& al)
             char* cigarData = new char[packedCigarLength]();
             std::memcpy(cigarData, packedCigar.data(), packedCigarLength);
             if (m_isBigEndian) {
-                for (size_t i = 0; i < packedCigarLength; ++i) {
+                for (size_t i = 0; i < packedCigarLength; i += sizeof(uint32_t)) {
                     BamTools::SwapEndian_32p(&cigarData[i]);
                 }
             }
@@ -500,8 +500,7 @@ void BamWriterPrivate::WriteAlignment(const BamAlignment& al)
             char* cigarData = new char[packedCigarLength]();
             std::memcpy(cigarData, packedCigar.data(), packedCigarLength);
             if (m_isBigEndian) {
-                for (size_t i = 0; i < packedCigarLength;
-                     ++i) {  // FIXME: similarly, this should be "i += 4", not "++i"
+                for (size_t i = 0; i < packedCigarLength; i += sizeof(uint32_t)) {
                     BamTools::SwapEndian_32p(&cigarData[i]);
                 }
             }