Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add GitHub release support for Linux and OSX #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Add GitHub release support for Linux and OSX #66

wants to merge 2 commits into from

Conversation

okapies
Copy link
Member

@okapies okapies commented Aug 9, 2018 •
edited
Loading

Ref. https://docs.travis-ci.com/user/deployment/releases/

TODO:

  • Add an archive which contains all dependent shared libraries instead of libmenoh itself
  • Add menoh_onnx_viewer to the package

@okapies okapies requested a review from msakai August 9, 2018 06:12
@msakai
Copy link
Member

msakai commented Aug 23, 2018

Sorry, I overlooked the review request...

@msakai
Copy link
Member

msakai commented Aug 23, 2018

It generally looks okay to me.

Some notes:

  • It might be better to package make install/striped version of libraries/executables, but I'm not sure as I'm not very familiar with cmake.
  • For packaging macOS binary, it might be better to specify osx_image: or MACOSX_DEPLOYMENT_TARGET to specify the lower bounds of supported macOS version.

@okapies
Copy link
Member Author

okapies commented Aug 23, 2018

Thanks for the comment. I'm inspecting the cmake configuration for static linking. I'll going further after these tasks are finished.

@msakai
Copy link
Member

msakai commented Sep 4, 2018

Note that now there are multiple jobs for same platform due to #81 and #83.
It is necessary not to upload same file from multiple jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msakai msakai Awaiting requested review from msakai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okapies @msakai