openvpn-client-export, added a 'save defaults' button and search option #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiBa-NL
force-pushed
the
openvpn-client-export
branch
from
ad647ea
to
5306690
Compare
|
I tried this out and it seems promising but didn't work for me aside from saving the settings. If we're going to store settings, the "default" should be saved per-server rather than for all. Different servers may have different advanced options or host name options, for example. The biggest problem is that the exporting didn't work at all. I tried three basic scenarios: SSL only, User Auth only, and SSL+User auth. In all cases, I could select a client but the export buttons did nothing at all. I tried in FF and Chrome, both up-to-date. I'd prefer to see the export buttons remain by the clients, moving them outside of the list makes it much more awkward and non-intuitive to use. It wasn't obvious to the user how they were supposed to proceed. So I do like the way the settings are handled, and the searching, but it needs some work yet. |
PiBa-NL
force-pushed
the
openvpn-client-export
branch
from
5306690
to
73f6380
Compare
|
New commit, that only provides the search option at this moment. The other parts will follow later with separate requests. |
netgate-git-updates
pushed a commit
that referenced
this pull request
Oct 24, 2016
netgate-git-updates
pushed a commit
that referenced
this pull request
Jul 8, 2019
Noteworthy changes in 0.12.4 - Added support for radius access-challenge (multifactor) authentication. - Fixed race condition when connect-script and disconnect-script are set, which could potentially cause a crash (#208). - Perform quicker cleanup of sessions which their user explicitly disconnected (#210). MFH: 2019Q3
netgate-git-updates
pushed a commit
that referenced
this pull request
Aug 4, 2022
Unbreaks port
upstream notes:
Bugfixes:
Resolves issue with waterfall appearing garbled on some systems. (PR #205)
Resolves issue with Restore Defaults restoring previous settings on exit. (PR #207)
Resolves issue with some sound valid sound devices causing PortAudio errors during startup checks. (PR #192)
Enhancements:
Removes requirement to restart FreeDV after using Restore Defaults. (PR #207)
Hides frequency display on main window unless PSK Reporter reporting is turned on. (PR #207)
Scales per-mode squelch settings when in multi-RX mode to reduce unwanted noise. (PR #186)
Single-thread mode is now the default when multi-RX is turned on. (PR #175)
Makes multi-RX mode the default. (PR #175)
Mic In/Speaker Out volume controls added to Filter window. (PR #208)
Cleans up UI for filters and makes the dialog non-modal. (PR #208)
Adds optional support for PulseAudio on Linux systems. (PR #194)
Documentation:
Resolves issue with PDF image placement. (PR #203)
Build System:
Uses more portable way of referring to Bash in build scripts. (PR #200)
User manual now installed along with executable. (PR #187)
macOS app bundle generated by CMake instead of manually. (PR #184)
Fail as soon as a step in the build script fails. (PR #183)
PR: ports/264769
Reported by: [email protected]
Tested by: [email protected]
netgate-git-updates
pushed a commit
that referenced
this pull request
Sep 26, 2022
* 2.6.1 - use 'zu' format string in deduper_dump() (#196) - ctype.h functions require int arguments. cygwin gcc enforces this. Update version to 2.6.1 * 2.6.2 - fix three memory leaks revealed by valgrind (#202) - see if we can remove the need for res_rcode() by changing the error path (#200) - use strtok_r() in preference to strsep(), for consistency and modernity (#203) - based on PR 204, refactor and comment for clarity (#205) * 2.6.3 - replace strtok_r() by new tokstr library - tokstr_h was a typo, thanks to codereview.stackexchange.com for finding it - attempt to work around gcc11 structure size checks (#207) - tokstr regions (#208) - Revised fix for issue 209: "error: unknown type ssize_t; did you mean _ssize_t?" (#211) - Can now build on Apple M1 processors by following the instructions (#212) - Clarify that not all macOS M1 machines have homebrew in the new /opt/homebrew location - Document again the HTTPS_PROXY environment variable * 2.6.4 - Issue 214: batch option parsing bug in tokstr library changes. (#215) Sponsored by: DomainTools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openvpn-client-export, added a 'save defaults' button and search option in user/certificate list, also moved the export buttons out of the list.