pfSense-pkg-apcupsd - new option for set shutdown behavior

[dbaio]

This quote from apccontrol explains:

[...]
# You can customize every single command creating an executable file (may be a
# script or a compiled program) and calling it the same as the $1 parameter
# passed by apcupsd to this script.
#
# After executing your script, apccontrol continues with the default action.
# If you do not want apccontrol to continue, exit your script with exit 
# code 99. E.g. "exit 99".
[...]

Suggested and tested by LucaTo from pfsense forum. Thank you.

[dennypage]

Calling /etc/rc.halt is probably not a good idea. If there are config changes happening, the shutdown could be denied which is not what you want. The pending loss of UPS power should be viewed as an overriding event, and higher priority than a pending config change.

[dbaio]

Good point @dennypage.
By default apcupsd through apccontrol call this:

   doshutdown)
      printf "Beginning Shutdown Sequence" | wall
      ${SHUTDOWN} -h now "apcupsd initiated shutdown"
   ;;

Could I revert this last commit ?

[dennypage]

I would think so, but you should wait for Renato’s agreement.

…

On Jan 30, 2017, at 11:59, Danilo G. Baio ***@***.***> wrote: Could I revert this last commit ?

[rbgarga]

The chances of this to happen are really small, it waits 30 seconds trying to acquire the lock, if it cannot after 30 seconds it means something is really wrong.

I'd say the best option would be to add a new parameter to rc.halt, -f, that would mean to force shutdown even if lock was not acquired.

[dennypage]

pfBlockerNG? Regardless, 30 seconds is really too long a potential delay in a critical power situation. Power failure is an overriding event. The value of trying to complete a config change a few seconds before power failure is pretty much nil. Definitely not worth the risk of corrupting the file system.

…

On Jan 31, 2017, at 08:37, Renato Botelho ***@***.***> wrote: The chances of this to happen are really small, it waits 30 seconds trying to acquire the lock, if it cannot after 30 seconds it means something is really wrong.

[rbgarga]

Yeah, indeed, you are right. @dbaio can you please revert it?

[dbaio]

Sure @rbgarga. Done.