Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squid4 ssl_crtd fix #740

Merged
merged 1 commit into from
Jan 7, 2020
Merged

squid4 ssl_crtd fix #740

merged 1 commit into from
Jan 7, 2020

Conversation

vktg
Copy link
Contributor

@vktg vktg commented Jan 2, 2020

Redmine Issue: https://redmine.pfsense.org/issues/9652
Ready for review

fixes sslcrtd_program program path for squid 3/4

@rbgarga
Copy link
Member

rbgarga commented Jan 3, 2020

@vktg please squash all commits into a single one with a meaning commit log message before we merge it

jim-p
jim-p requested changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@jim-p jim-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a part of this pull request, you must increase PORTVERSION or add a PORTREVISION line in the package Makefile. Without this version increase, the package will not be rebuilt to include the new change.

See https://www.netgate.com/docs/pfsense/development/developer-style-guide.html#ports-packages-specific-rules

@rbgarga
Copy link
Member

rbgarga commented Jan 3, 2020

As a part of this pull request, you must increase PORTVERSION or add a PORTREVISION line in the package Makefile. Without this version increase, the package will not be rebuilt to include the new change.

See https://www.netgate.com/docs/pfsense/development/developer-style-guide.html#ports-packages-specific-rules

@vktg if you want to keep this one as it is, I can merge it together with #725 which already bumped version

@vktg
Copy link
Contributor Author

vktg commented Jan 3, 2020

Yes, you can merge it with #725

@rbgarga
Copy link
Member

rbgarga commented Jan 3, 2020

Yes, you can merge it with #725

Sure. Please just squash all commits into a single one with a meaning commit log message and I'll take care

@vktg
Copy link
Contributor Author

vktg commented Jan 3, 2020

done, squashed

@rbgarga rbgarga mentioned this pull request Jan 7, 2020
Merged
netgate-git-updates pushed a commit that referenced this pull request Jan 7, 2020
@rbgarga
Merge pull request #740 from vktg/squidssldbfix
b592411
@netgate-git-updates netgate-git-updates merged commit 0df32d8 into pfsense:devel Jan 7, 2020
netgate-git-updates pushed a commit that referenced this pull request May 20, 2020
@fernape
devel/sentry-cli: Update to 1.53.0
04c5e96 
ChangeLog: https://github.com/getsentry/sentry-cli/releases/1.53.0

 * feat: releases deploys JavaScript API (#741)
 * fix: --log-level should be case insensitive (#740)

PR:	246576
Submitted by:	[email protected] (maintainer)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-p jim-p jim-p requested changes

@rbgarga rbgarga rbgarga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vktg @rbgarga @jim-p @netgate-git-updates