Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squid LDAP auth fix. Issue #10379 #811

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

vktg
Copy link
Contributor

@vktg vktg commented Mar 28, 2020

Redmine Issue: https://redmine.pfsense.org/issues/10379
Ready for review

pfsense 2.4.4p3 with all packages updated, using squid with LDAP authentication was working perfectly, server with 2 years or more of smooth operation in previous updates, after upgrading to 2.4.5 both LDAP and RADIUS permanently apply for authentication even using valid credentials. Diagnostic/authentication testing successfully validates users. Only the Squid that is not working properly.

Changes in PR #729 create an invalid configuration string:
auth_param basic program /usr/local/libexec/squid/basic_ldap_auth -v 3 -b 'CN=Users,DC=test,DC=int' -D 'CN=Administrator,CN=Users,DC=test,DC=int' '-w 123' -f 'sAMAccountName=%s' -u 'cn' -P '192.168.1.10:389'

This PR fix it to:
'CN=Users,DC=test,DC=int' -D 'CN=Administrator,CN=Users,DC=test,DC=int' -w '123' -f 'sAMAccountName=%s' -u 'cn' -P '192.168.1.10:389'
and adds '-R do not follow referrals' option to WebGUI

@ismael-azambuja
Copy link

ismael-azambuja commented Mar 28, 2020

Hi, i test this fix, but dont work here...
0.4.44_8 OK : auth_param basic program /usr/local/libexec/squid/basic_ldap_auth -v 3 -b DC=UERGS,DC=RS -D CN=SQUID,OU=ADMINS,DC=UERGS,DC=RS -w password -f "sAMAccountName=%s" -u uid -P 10.34.0.16:389

0.4.44_15 Problem, I tried and it did not work here:

auth_param basic program /usr/local/libexec/squid/basic_ldap_auth -v 3 -b 'DC=UERGS,DC=RS' -D 'CN=SQUID,OU=ADMINS,DC=UERGS,DC=RS' '-w password' -f 'sAMAccountName=%s' -u 'uid' -P '172.16.0.16:389'

auth_param basic program /usr/local/libexec/squid/basic_ldap_auth -v 3 -b 'DC=UERGS,DC=RS' -D 'CN=SQUID,OU=ADMINS,DC=UERGS,DC=RS' -w 'password' -f 'sAMAccountName=%s' -u 'uid' -P '172.16.0.16:389'

auth_param basic program /usr/local/libexec/squid/basic_ldap_auth -v 3 -b DC=UERGS,DC=RS -D CN=SQUID,OU=ADMINS,DC=UERGS,DC=RS -w password -f sAMAccountName=%s -u uid -P 172.16.0.16:389

@netgate-git-updates netgate-git-updates merged commit 53b3016 into pfsense:devel Mar 30, 2020
@o71
Copy link

o71 commented Mar 30, 2020

Hello @vktg, @jim-p ,

I tested it but I have 2 problems with the "-R" parameter. I explain it here : https://redmine.pfsense.org/issues/10379#note-13

I don't understand, I try with a test pfsense, same problem.

Thanks a lot

@o71
Copy link

o71 commented Mar 31, 2020

Hi @vktg and @jim-p

I give you a solution which works here : https://redmine.pfsense.org/issues/10379#note-16

Can you update the pkg ?

Thanks a lot

@vktg
Copy link
Contributor Author

vktg commented Mar 31, 2020

See #814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants