Skip to content
This repository has been archived by the owner on Jan 22, 2018. It is now read-only.

Add squid3 reverse-proxy security options #1216

Closed
wants to merge 3 commits into from
Closed

Add squid3 reverse-proxy security options #1216

wants to merge 3 commits into from

Conversation

geijt
Copy link
Contributor

@geijt geijt commented Dec 13, 2015

Added squid3 reverse-proxy security options to control the reverse-proxy protocols and ciphers.

Added squid3 reverse-proxy security options to control the reverse-proxy
protocols and ciphers.
# Conflicts:
#	config/squid3/34/squid.xml
#	pkg_config.10.xml
@doktornotor
Copy link
Contributor

Bunch of notes here:

  • 100+ lines of code to generate DH params? Seriously? When it's already there and if someone really desires they can generate their own in 3 lines?
  • Why is disable_sslv2, disable_sslv3 even an option, plus disabled by default?
  • Wouldn't a per-server (default off) checkbox with something like "Allow shitty crypto" make much more sense for cases where there's really no way around it, plus everything else HTTPS defaulting to some sensible defaults as already done for the HTTPS proxy?
  • Finally - whatever gets done here must be done for the FreeBSD-ports package as well; these are no longer synced.

@cbuechler
Copy link

The DH parameters generation should go. Just use those that are there already.

There isn't any valid reason at this point to allow use of SSLv2 and v3 at all, much less enabled by default. That should just be off with no option to enable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants