Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pgRouting 3.4 do not build docs when sphinx is too low or missing #2401

Closed
Tracked by #2399
cvvergara opened this issue Oct 6, 2022 · 3 comments · Fixed by #2405
Closed
Tracked by #2399

pgRouting 3.4 do not build docs when sphinx is too low or missing #2401

cvvergara opened this issue Oct 6, 2022 · 3 comments · Fixed by #2405
Assignees
@cvvergara
Labels
bug
Milestone
Release 3.4.1

Comments

@cvvergara
Copy link
Member

#2399 on 3.4.0
@cvvergara cvvergara added the bug label Oct 6, 2022
@cvvergara cvvergara added this to the Release 3.4.1 milestone Oct 6, 2022
@cvvergara cvvergara self-assigned this Oct 6, 2022
@cvvergara cvvergara mentioned this issue Oct 6, 2022
Closed
3 tasks
@cvvergara cvvergara changed the title pgRouting 3.4.0 does not build in focal pgRouting 3.4.0 probably does not build in focal Oct 6, 2022
@robe2 robe2 changed the title pgRouting 3.4.0 probably does not build in focal pgRouting 3.4.0 docs probably does not build in focal Oct 6, 2022
@cvvergara cvvergara added Invalid and removed bug labels Oct 6, 2022
@cvvergara cvvergara removed this from the Release 3.4.1 milestone Oct 6, 2022
@robe2
Copy link
Member

robe2 commented Oct 6, 2022

I think that is fine and no need to try to get it to build in focal.
The docs are already part of the tagged release. I'd just make sure doc building is disabled if sphinx < 4.0 since we have that set here as the minimum https://github.com/pgRouting/pgrouting/blob/main/CMakeLists.txt#L61

@robe2 robe2 closed this as completed Oct 6, 2022
@df7cb
Copy link

df7cb commented Oct 7, 2022

Debian wants to be able to modify the source, so disabling the doc build isn't ideal. (But maybe acceptable if that's just in old distributions.)

@cvvergara cvvergara reopened this Oct 7, 2022
@cvvergara
Copy link
Member Author

Thanks, I am working on it for 3.4.1

@cvvergara cvvergara mentioned this issue Oct 7, 2022
Merged
@cvvergara cvvergara added bug and removed Invalid labels Oct 7, 2022
cvvergara added a commit to cvvergara/pgrouting that referenced this issue Oct 7, 2022
@cvvergara
[pgRouting#2401][build][doc] not building doc when sphinx does not ex…
048fa09 
…ist or too low
cvvergara added a commit to cvvergara/pgrouting that referenced this issue Oct 7, 2022
@cvvergara
[pgRouting#2401][build][doc] not building doc when sphinx does not ex…
19071f8 
…ist or too low
@cvvergara cvvergara changed the title pgRouting 3.4.0 docs probably does not build in focal pgRouting 3.4.0 do not build docs when sphinx is too low or missing Oct 7, 2022
@cvvergara cvvergara added this to the Release 3.4.1 milestone Oct 7, 2022
cvvergara added a commit to cvvergara/pgrouting that referenced this issue Oct 7, 2022
@cvvergara
[news] adding issue closes pgRouting#2401
0cac658
@cvvergara cvvergara changed the title pgRouting 3.4.0 do not build docs when sphinx is too low or missing pgRouting 3.4 do not build docs when sphinx is too low or missing Oct 7, 2022
cvvergara added a commit to cvvergara/pgrouting that referenced this issue Oct 7, 2022
@cvvergara
[pgRouting#2401][build][doc] not building doc when sphinx does not ex…
ad992fc 
…ist or too low
cvvergara added a commit to cvvergara/pgrouting that referenced this issue Oct 7, 2022
@cvvergara
[news] adding issue closes pgRouting#2401
9d28e2f
cvvergara added a commit to cvvergara/pgrouting that referenced this issue Oct 8, 2022
@cvvergara
[news] adding issue closes pgRouting#2401
063e668
cvvergara added a commit to cvvergara/pgrouting that referenced this issue Oct 10, 2022
@cvvergara
[news] adding issue closes pgRouting#2401
668355c
cvvergara added a commit that referenced this issue Oct 11, 2022
@cvvergara
[#2401][build][doc] not building doc when sphinx does not exist or to…
23053da 
…o low
cvvergara added a commit that referenced this issue Oct 11, 2022
@cvvergara
[news] adding issue closes #2401
b7ec138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvvergara cvvergara

Labels
bug
Projects
None yet
Milestone
Release 3.4.1
Development

Successfully merging a pull request may close this issue.

Fixing issues 2398 & 2401 cvvergara/pgrouting
3 participants
@df7cb @robe2 @cvvergara